Stream: git-wasmtime

Topic: wasmtime / PR #7351 wasi-http: Return an optional trailer...

Wasmtime GitHub notifications bot (Oct 24 2023 at 16:52):

elliottt opened PR #7351 from elliottt:trevor/optional-trailers to bytecodealliance:main:

Avoid creating a new fields resource to represent the case where no trailers were present in an incoming-body by making the returned trailers optional. This mirrors the optional trailers parameter to outgoing-body.finish.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 24 2023 at 16:52):

elliottt requested pchickey for a review on PR #7351.

Wasmtime GitHub notifications bot (Oct 24 2023 at 16:52):

elliottt requested wasmtime-core-reviewers for a review on PR #7351.

Wasmtime GitHub notifications bot (Oct 24 2023 at 16:52):

elliottt edited PR #7351:

Avoid creating a new fields resource to represent the case where no trailers were present in an incoming-body by making the returned trailers optional. This mirrors the optional trailers parameter to outgoing-body.finish.

Fixes #7275

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 26 2023 at 16:30):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Oct 26 2023 at 17:13):

elliottt merged PR #7351.

Last updated: Nov 22 2024 at 17:03 UTC