Stream: git-wasmtime

Topic: wasmtime / PR #7345 wasmtime: Fix Bench API Build


view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2023 at 11:20):

afonso360 opened PR #7345 from afonso360:fix-bench-build to bytecodealliance:main:

:wave: Hey,

It looks like the bench-api package is broken and no longer builds. I think we just need to add these features to get the necessary API's enabled.

I've also added a check in CI that runs cargo check on this package to ensure that this does not regress in the future.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2023 at 11:20):

afonso360 requested fitzgen for a review on PR #7345.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2023 at 11:20):

afonso360 requested wasmtime-core-reviewers for a review on PR #7345.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2023 at 11:20):

afonso360 requested wasmtime-default-reviewers for a review on PR #7345.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2023 at 11:26):

afonso360 edited PR #7345:

:wave: Hey,

It looks like the bench-api package is broken and no longer builds. I think we just need to add these features to get the necessary API's enabled. I'm also not sure if I should instead enable default-features = true to get all of them.

I've also added a check in CI that runs cargo check on this package to ensure that this does not regress in the future.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2023 at 11:37):

afonso360 updated PR #7345.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2023 at 11:39):

afonso360 edited PR #7345:

:wave: Hey,

It looks like the bench-api package is broken and no longer builds. I think we just need to add the default features to get the necessary API's enabled.

I've also added a check in CI that runs cargo check on this package to ensure that this does not regress in the future.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2023 at 14:20):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2023 at 15:09):

alexcrichton merged PR #7345.


Last updated: Nov 22 2024 at 17:03 UTC