afonso360 opened PR #7345 from afonso360:fix-bench-build
to bytecodealliance:main
:
:wave: Hey,
It looks like the bench-api package is broken and no longer builds. I think we just need to add these features to get the necessary API's enabled.
I've also added a check in CI that runs
cargo check
on this package to ensure that this does not regress in the future.
afonso360 requested fitzgen for a review on PR #7345.
afonso360 requested wasmtime-core-reviewers for a review on PR #7345.
afonso360 requested wasmtime-default-reviewers for a review on PR #7345.
afonso360 edited PR #7345:
:wave: Hey,
It looks like the bench-api package is broken and no longer builds. I think we just need to add these features to get the necessary API's enabled. I'm also not sure if I should instead enable
default-features = true
to get all of them.I've also added a check in CI that runs
cargo check
on this package to ensure that this does not regress in the future.
afonso360 updated PR #7345.
afonso360 edited PR #7345:
:wave: Hey,
It looks like the bench-api package is broken and no longer builds. I think we just need to add the default features to get the necessary API's enabled.
I've also added a check in CI that runs
cargo check
on this package to ensure that this does not regress in the future.
alexcrichton submitted PR review.
alexcrichton merged PR #7345.
Last updated: Nov 22 2024 at 17:03 UTC