Wasmtime GitHub notifications bot (Oct 24 2023 at 07:43): Wasmtime GitHub notifications bot (Oct 24 2023 at 07:43):Solo-steven opened PR #7344 from Solo-steven:steven/issue-5869 to bytecodealliance:main:
This PR implement second part of issue #5869 .
As lowering selection based on
fcmpa declare a helper function for loweringicmp-based select instruction.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 24 2023 at 07:43):Solo-steven requested wasmtime-compiler-reviewers for a review on PR #7344.
Wasmtime GitHub notifications bot (Oct 24 2023 at 07:43):Solo-steven requested cfallin for a review on PR #7344.
Wasmtime GitHub notifications bot (Oct 24 2023 at 07:46):Solo-steven edited PR #7344:
This PR implement second part of issue #5869 .
As lowering
selectinstruction based onfcmpa declare a helper function for loweringicmp-based select instruction.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 24 2023 at 07:56):Solo-steven edited PR #7344:
This PR implements the second part of issue #5869 .
As lowering the
selectinstruction based onfcmp. I declare a helper function for loweringicmp-based select instruction.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 24 2023 at 22:37):cfallin submitted PR review:
Thanks! One formatting nit below, otherwise this seems correct.
Do you expect codegen to improve for any combination of compare and select instructions? If so, could we add a test showing that?
Wasmtime GitHub notifications bot (Oct 24 2023 at 22:37):cfallin submitted PR review:
Thanks! One formatting nit below, otherwise this seems correct.
Do you expect codegen to improve for any combination of compare and select instructions? If so, could we add a test showing that?
Wasmtime GitHub notifications bot (Oct 24 2023 at 22:37):cfallin created PR review comment:
formatting nit: remove the space between
band the right-paren?
Wasmtime GitHub notifications bot (Oct 25 2023 at 08:31):Solo-steven updated PR #7344.
Wasmtime GitHub notifications bot (Oct 26 2023 at 02:42):Solo-steven requested cfallin for a review on PR #7344.
Wasmtime GitHub notifications bot (Oct 26 2023 at 15:56):cfallin submitted PR review:
Looks good, thanks! I didn't necessarily expect any codegen changes either, I was just curious if there were any intended. This looks like a pure refactor which is perfectly fine!
Wasmtime GitHub notifications bot (Oct 26 2023 at 16:49):cfallin merged PR #7344.
Last updated: Dec 23 2024 at 12:05 UTC