Stream: git-wasmtime

Topic: wasmtime / PR #7340 riscv64: Refactor float-to-int trappi...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 23 2023 at 21:52):

alexcrichton requested afonso360 for a review on PR #7340.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 23 2023 at 21:52):

alexcrichton opened PR #7340 from alexcrichton:rv64-fflags to bytecodealliance:main:

This commit refactors the fcvt_to_{s,u}int conversions in the riscv64
backend to build on the work in https://github.com/bytecodealliance/wasmtime/pull/7327. These two instructions currently
have multiple branches in them to check for traps when the float is out
of bounds. This is additionally signaled via the fflags CSR however so
this is an attempt to trim some branches/constants/etc and instead check
the fflags CSR after the operation. This requires clearing the CSR
just beforehand, however. This additionally doesn't work for 8/16-bit
types because the hardware doesn't set flags for those.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2023 at 19:10):

alexcrichton closed without merge PR #7340.

Last updated: Nov 22 2024 at 16:03 UTC