Stream: git-wasmtime

Topic: wasmtime / PR #7338 Fix native feature detect in "min" bu...

Wasmtime GitHub notifications bot (Oct 23 2023 at 18:46):

alexcrichton opened PR #7338 from alexcrichton:min-std-detect to bytecodealliance:main:

With a custom standard library disabling all features means disabling some support for feature-detection macros of the native platform. This meant that wasmtime compile output locally wasn't runnable in wasmtime-min run because it couldn't correctly detect that features were in fact available.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 23 2023 at 18:46):

alexcrichton requested wasmtime-default-reviewers for a review on PR #7338.

Wasmtime GitHub notifications bot (Oct 23 2023 at 18:46):

alexcrichton requested cfallin for a review on PR #7338.

Wasmtime GitHub notifications bot (Oct 23 2023 at 18:52):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Oct 23 2023 at 18:55):

alexcrichton has enabled auto merge for PR #7338.

Wasmtime GitHub notifications bot (Oct 23 2023 at 21:11):

alexcrichton merged PR #7338.

Last updated: Oct 23 2024 at 20:03 UTC