Wasmtime GitHub notifications bot (Oct 21 2023 at 13:51): Wasmtime GitHub notifications bot (Oct 21 2023 at 13:51):afonso360 opened PR #7320 from afonso360:interpret-libcalls to bytecodealliance:main:
:wave: Hey,
This is a follow up to one of @alexcrichton 's comments in #7203, where he found some fuzzing issues with RISC-V. I'm still investigating those, but this solves one of them.
Fuzzgen can currently generate a number of libcalls, these also need to be given a handler when building the interpreter. We currently have that in the fuzzgen interpreter, but don't have an equivalent in
test interpret, so when copying a failing clif case from fuzzgen it's possible to get a second error if the testcase references some libcall.I've been currently just stripping out libcalls from failing clif cases, but probably should have addressed this a while ago.
This adds the same libcalls that we have in the fuzzer, it might be worth having a default interpreter implementation in
cranelift-interpreterthat adds these, not entirely sure.
Wasmtime GitHub notifications bot (Oct 21 2023 at 13:51):afonso360 requested wasmtime-compiler-reviewers for a review on PR #7320.
Wasmtime GitHub notifications bot (Oct 21 2023 at 13:51):afonso360 requested fitzgen for a review on PR #7320.
Wasmtime GitHub notifications bot (Oct 21 2023 at 13:51):afonso360 requested wasmtime-default-reviewers for a review on PR #7320.
Wasmtime GitHub notifications bot (Oct 21 2023 at 19:45):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Oct 21 2023 at 20:25):alexcrichton merged PR #7320.
Last updated: Dec 23 2024 at 12:05 UTC