Wasmtime GitHub notifications bot (Oct 19 2023 at 22:41): Wasmtime GitHub notifications bot (Oct 19 2023 at 22:41):alexcrichton opened PR #7301 from alexcrichton:swap-dir-args to bytecodealliance:main:
This commit changes the
--dirargument on thewasmtimeCLI to beHOST::GUESTrather thanGUEST::HOST. This matches Docker for example and is a little more consistent with only--dir pathwhere the first argument is always treated as a host directory.In terms of breaking-ness the movement from
--mapdirto--dirhasn't been released with Wasmtime 14 yet so my hope is that this can land on bothmainand Wasmtime 14.0.0 before it's released to avoid any breakage other than existing scripts migrating from--mapdirto--dir.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 19 2023 at 22:41):alexcrichton requested fitzgen for a review on PR #7301.
Wasmtime GitHub notifications bot (Oct 19 2023 at 22:41):alexcrichton requested wasmtime-core-reviewers for a review on PR #7301.
Wasmtime GitHub notifications bot (Oct 19 2023 at 22:41):alexcrichton requested wasmtime-default-reviewers for a review on PR #7301.
Wasmtime GitHub notifications bot (Oct 19 2023 at 22:44):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Oct 19 2023 at 22:48):alexcrichton has enabled auto merge for PR #7301.
Wasmtime GitHub notifications bot (Oct 20 2023 at 00:04):alexcrichton merged PR #7301.
Last updated: Oct 23 2024 at 20:03 UTC