Stream: git-wasmtime

Topic: wasmtime / PR #7301 Swap the order of directories in `--dir`


view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2023 at 22:41):

alexcrichton opened PR #7301 from alexcrichton:swap-dir-args to bytecodealliance:main:

This commit changes the --dir argument on the wasmtime CLI to be HOST::GUEST rather than GUEST::HOST. This matches Docker for example and is a little more consistent with only --dir path where the first argument is always treated as a host directory.

In terms of breaking-ness the movement from --mapdir to --dir hasn't been released with Wasmtime 14 yet so my hope is that this can land on both main and Wasmtime 14.0.0 before it's released to avoid any breakage other than existing scripts migrating from --mapdir to --dir.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2023 at 22:41):

alexcrichton requested fitzgen for a review on PR #7301.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2023 at 22:41):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7301.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2023 at 22:41):

alexcrichton requested wasmtime-default-reviewers for a review on PR #7301.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2023 at 22:44):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2023 at 22:48):

alexcrichton has enabled auto merge for PR #7301.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2023 at 00:04):

alexcrichton merged PR #7301.


Last updated: Dec 23 2024 at 12:05 UTC