Stream: git-wasmtime

Topic: wasmtime / PR #7289 Implement support for `thread` in `*....

Wasmtime GitHub notifications bot (Oct 18 2023 at 21:08):

alexcrichton opened PR #7289 from alexcrichton:test-threads-in-wast to bytecodealliance:main:

This commit implements support for thread and wait in *.wast files and imports the upstream spec test suite from the threads proposal. This additionally and hopefully makes it a bit easier to write threaded tests in the future if necessary too.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 18 2023 at 21:08):

alexcrichton requested pchickey for a review on PR #7289.

Wasmtime GitHub notifications bot (Oct 18 2023 at 21:08):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7289.

Wasmtime GitHub notifications bot (Oct 18 2023 at 21:21):

alexcrichton updated PR #7289.

Wasmtime GitHub notifications bot (Oct 18 2023 at 23:28):

abrown submitted PR review:

Makes sense to me!

Wasmtime GitHub notifications bot (Oct 18 2023 at 23:29):

abrown submitted PR review:

Makes sense to me! So I guess we will get rid of all of these imported *.wast files once the upstream testsuite contains them?

Wasmtime GitHub notifications bot (Oct 19 2023 at 00:36):

alexcrichton merged PR #7289.

Last updated: Nov 22 2024 at 16:03 UTC