Stream: git-wasmtime

Topic: wasmtime / PR #7288 wasi-http: Allow embedder to manage o...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 18 2023 at 20:19):

dicej requested elliottt for a review on PR #7288.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 18 2023 at 20:19):

dicej requested alexcrichton for a review on PR #7288.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 18 2023 at 20:19):

dicej requested wasmtime-core-reviewers for a review on PR #7288.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 18 2023 at 20:19):

dicej opened PR #7288 from dicej:wasi-http-override-send-request to bytecodealliance:main:

This adds a new send_request method to WasiHttpView, allowing embedders to override the default implementation with their own if the desire. The default implementation behaves exactly as before.

I've also added a few new wasi-http tests: one to test the above, and two others to test streaming and concurrency. These tests are ports of the test_wasi_http_echo and test_wasi_http_hash_all tests in the Spin integration test suite. The component they instantiate is likewise ported from the Spin
wasi-http-rust-streaming-outgoing-body component.

Fixes #7259

view this post on Zulip Wasmtime GitHub notifications bot (Oct 18 2023 at 20:19):

dicej requested wasmtime-default-reviewers for a review on PR #7288.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 18 2023 at 20:48):

dicej updated PR #7288.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 18 2023 at 21:05):

dicej updated PR #7288.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 18 2023 at 21:23):

dicej updated PR #7288.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 18 2023 at 21:24):

dicej edited PR #7288:

This adds a new send_request method to WasiHttpView, allowing embedders to override the default implementation with their own if they desire. The default implementation behaves exactly as before.

I've also added a few new wasi-http tests: one to test the above, and two others to test streaming and concurrency. These tests are ports of the test_wasi_http_echo and test_wasi_http_hash_all tests in the Spin integration test suite. The component they instantiate is likewise ported from the Spin
wasi-http-rust-streaming-outgoing-body component.

Fixes #7259

view this post on Zulip Wasmtime GitHub notifications bot (Oct 18 2023 at 23:02):

elliottt submitted PR review:

This looks great to me, thank you!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 18 2023 at 23:02):

elliottt submitted PR review:

This looks great to me, thank you!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 18 2023 at 23:02):

elliottt created PR review comment:

This is so much simpler than what I was assuming we'd need, nice work!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 18 2023 at 23:46):

elliottt merged PR #7288.

Last updated: Dec 23 2024 at 12:05 UTC