Stream: git-wasmtime

Topic: wasmtime / PR #7284 riscv64: Improve scalar_to_vector for...

Wasmtime GitHub notifications bot (Oct 18 2023 at 18:04):

BieVic requested wasmtime-compiler-reviewers for a review on PR #7284.

Wasmtime GitHub notifications bot (Oct 18 2023 at 18:04):

BieVic requested cfallin for a review on PR #7284.

Wasmtime GitHub notifications bot (Oct 18 2023 at 18:04):

BieVic opened PR #7284 from BieVic:rv64-vmerge-vim to bytecodealliance:main:

This simple improvement adds a rule for the vmerge.vim instruction and an imm5_from_value extractor.
Closes #7189

Wasmtime GitHub notifications bot (Oct 18 2023 at 21:46):

afonso360 submitted PR review:

This looks great to me :tada: . Thanks for working on this!

Could you also add a run test over at cranelift/filetests/filetests/runtests/simd-scalartovector.clif so that this also gets tested that way in CI?

Wasmtime GitHub notifications bot (Oct 18 2023 at 21:46):

afonso360 submitted PR review:

This looks great to me :tada: . Thanks for working on this!

Could you also add a run test over at cranelift/filetests/filetests/runtests/simd-scalartovector.clif so that this also gets tested that way in CI?

Wasmtime GitHub notifications bot (Oct 18 2023 at 21:46):

afonso360 created PR review comment:

(rule (replicated_imm5 (splat (imm5_from_value n))) n)

Now that we've extracted imm5_from_value into a separate rule, we should also use it here, so that we don't have duplicate definitions.

Wasmtime GitHub notifications bot (Oct 19 2023 at 15:20):

BieVic updated PR #7284.

Wasmtime GitHub notifications bot (Oct 19 2023 at 15:41):

afonso360 submitted PR review:

Looks great, Thanks!

Wasmtime GitHub notifications bot (Oct 19 2023 at 15:41):

afonso360 has enabled auto merge for PR #7284.

Wasmtime GitHub notifications bot (Oct 19 2023 at 16:52):

afonso360 merged PR #7284.

Last updated: Oct 23 2024 at 20:03 UTC