BieVic requested wasmtime-compiler-reviewers for a review on PR #7284.
BieVic requested cfallin for a review on PR #7284.
BieVic opened PR #7284 from BieVic:rv64-vmerge-vim
to bytecodealliance:main
:
This simple improvement adds a rule for the
vmerge.vim
instruction and animm5_from_value
extractor.
Closes #7189
afonso360 submitted PR review:
This looks great to me :tada: . Thanks for working on this!
Could you also add a run test over at
cranelift/filetests/filetests/runtests/simd-scalartovector.clif
so that this also gets tested that way in CI?
afonso360 submitted PR review:
This looks great to me :tada: . Thanks for working on this!
Could you also add a run test over at
cranelift/filetests/filetests/runtests/simd-scalartovector.clif
so that this also gets tested that way in CI?
afonso360 created PR review comment:
(rule (replicated_imm5 (splat (imm5_from_value n))) n)
Now that we've extracted
imm5_from_value
into a separate rule, we should also use it here, so that we don't have duplicate definitions.
BieVic updated PR #7284.
afonso360 submitted PR review:
Looks great, Thanks!
afonso360 has enabled auto merge for PR #7284.
afonso360 merged PR #7284.
Last updated: Dec 23 2024 at 12:05 UTC