Stream: git-wasmtime

Topic: wasmtime / PR #7262 PCC: rework default-facts somewhat.


view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2023 at 23:19):

cfallin requested fitzgen for a review on PR #7262.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2023 at 23:19):

cfallin requested wasmtime-compiler-reviewers for a review on PR #7262.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2023 at 23:19):

cfallin opened PR #7262 from cfallin:pcc-no-default-facts to bytecodealliance:main:

This removes the need for the awkward "max-range fact is subsumed by anything" rule noted by @fitzgen in this comment. It also makes checking a little more efficient and logically clear, as only the facts that the frontend/producer added are verified, rather than all default facts as well.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2023 at 23:55):

fitzgen submitted PR review:

Nice!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 17 2023 at 00:37):

fitzgen merged PR #7262.


Last updated: Dec 23 2024 at 12:05 UTC