Wasmtime GitHub notifications bot (Oct 16 2023 at 23:19): Wasmtime GitHub notifications bot (Oct 16 2023 at 23:19):cfallin requested fitzgen for a review on PR #7262.
Wasmtime GitHub notifications bot (Oct 16 2023 at 23:19):cfallin requested wasmtime-compiler-reviewers for a review on PR #7262.
Wasmtime GitHub notifications bot (Oct 16 2023 at 23:19):cfallin opened PR #7262 from cfallin:pcc-no-default-facts to bytecodealliance:main:
This removes the need for the awkward "max-range fact is subsumed by anything" rule noted by @fitzgen in this comment. It also makes checking a little more efficient and logically clear, as only the facts that the frontend/producer added are verified, rather than all default facts as well.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 16 2023 at 23:55):fitzgen submitted PR review:
Nice!
Wasmtime GitHub notifications bot (Oct 17 2023 at 00:37):fitzgen merged PR #7262.
Last updated: Nov 22 2024 at 17:03 UTC