Stream: git-wasmtime

Topic: wasmtime / PR #7254 Fix profiling the first function in a...

Wasmtime GitHub notifications bot (Oct 16 2023 at 15:58):

alexcrichton opened PR #7254 from alexcrichton:profile-first-function to bytecodealliance:main:

This commit removes a clause in register_module which was preventing perf profiling the first function in a module because it was located at address 0. This check is relatively dated at this point and I think I originally added it in error (and/or it was copied from somewhere else), so this commit removes it.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 16 2023 at 15:58):

alexcrichton requested pchickey for a review on PR #7254.

Wasmtime GitHub notifications bot (Oct 16 2023 at 15:58):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7254.

Wasmtime GitHub notifications bot (Oct 16 2023 at 16:07):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Oct 16 2023 at 16:07):

alexcrichton has enabled auto merge for PR #7254.

Wasmtime GitHub notifications bot (Oct 16 2023 at 17:04):

alexcrichton merged PR #7254.

Last updated: Oct 23 2024 at 20:03 UTC