Wasmtime GitHub notifications bot (Oct 16 2023 at 14:03): Wasmtime GitHub notifications bot (Oct 16 2023 at 14:03):alexcrichton requested afonso360 for a review on PR #7252.
Wasmtime GitHub notifications bot (Oct 16 2023 at 14:03):alexcrichton requested elliottt for a review on PR #7252.
Wasmtime GitHub notifications bot (Oct 16 2023 at 14:03):alexcrichton opened PR #7252 from alexcrichton:rv64-zbs to bytecodealliance:main:
This commit extends the riscv64 backend with instructions from the
Zbsextension. I did this awhile back for the bmi{1,2} instructions for x64 and this is mostly for completeness's sake rather than performance or anything like that, and because I had a long plane ride!
Wasmtime GitHub notifications bot (Oct 16 2023 at 14:03):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #7252.
Wasmtime GitHub notifications bot (Oct 17 2023 at 10:46):afonso360 submitted PR review:
Nice! Some small suggestions if you'd like to expand on this.
With so many patterns here I think it might be worth eventually creating intermediate instructions in CLIF and moving some of these rules to the egraphs layer. But this looks good to me!
Wasmtime GitHub notifications bot (Oct 17 2023 at 10:46):afonso360 submitted PR review:
Nice! Some small suggestions if you'd like to expand on this.
With so many patterns here I think it might be worth eventually creating intermediate instructions in CLIF and moving some of these rules to the egraphs layer. But this looks good to me!
Wasmtime GitHub notifications bot (Oct 17 2023 at 10:46):afonso360 created PR review comment:
Also, perhaps we should add equivalent rules for these with swapped arguments. i.e.
(band (bnot ...) y)we have them for the other instructions but not forbclr.
Wasmtime GitHub notifications bot (Oct 17 2023 at 10:46):afonso360 created PR review comment:
A small suggestion here would be to change this to
(u64_sub (ty_bits ty) 1)so that we could also apply these patterns to i16 and i8.
Wasmtime GitHub notifications bot (Oct 17 2023 at 10:47):afonso360 edited PR review comment.
Wasmtime GitHub notifications bot (Oct 17 2023 at 10:47):afonso360 submitted PR review:
Nice! Some small suggestions if you'd like to expand on this.
With so many patterns here I think it might be worth eventually creating intermediate instructions in CLIF and moving some of these rules to the egraphs layer. But this looks good to me!
I've also been running the fuzzer on this branch and it hasn't found anything yet.
Wasmtime GitHub notifications bot (Oct 17 2023 at 10:48):afonso360 submitted PR review:
Nice! Some small suggestions if you'd like to expand on this.
With so many patterns here I think it might be worth eventually creating intermediate instructions in CLIF and moving some of these rules to the egraphs layer. But this looks good to me! (cc: #1067)
I've also been running the fuzzer on this branch and it hasn't found anything yet.
Wasmtime GitHub notifications bot (Oct 17 2023 at 10:50):afonso360 submitted PR review:
Nice! Some small suggestions if you'd like to expand on this.
With so many patterns here I think it might be worth eventually creating intermediate instructions in CLIF and moving some of these rules to the egraphs layer. But this looks good to me!
I've also been running the fuzzer on this branch and it hasn't found anything yet.
Wasmtime GitHub notifications bot (Oct 17 2023 at 15:04):alexcrichton updated PR #7252.
Wasmtime GitHub notifications bot (Oct 17 2023 at 15:04):alexcrichton has enabled auto merge for PR #7252.
Wasmtime GitHub notifications bot (Oct 17 2023 at 16:27):alexcrichton merged PR #7252.
Last updated: Oct 23 2024 at 20:03 UTC