Stream: git-wasmtime

Topic: wasmtime / PR #7250 riscv64: Optimize `select_spectre_guard`

Wasmtime GitHub notifications bot (Oct 16 2023 at 13:53):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #7250.

Wasmtime GitHub notifications bot (Oct 16 2023 at 13:53):

alexcrichton requested abrown for a review on PR #7250.

Wasmtime GitHub notifications bot (Oct 16 2023 at 13:53):

alexcrichton opened PR #7250 from alexcrichton:rv64-spectre-improvements to bytecodealliance:main:

This commit optimizes some select_spectre_guard patterns which are frequently generated with the wasm backend when dynamic bounds checks are enabled by pattern-matching when one of the values being selected is zero. This enables shaving off a few instructions which can be constant folded away.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 16 2023 at 13:53):

alexcrichton requested afonso360 for a review on PR #7250.

Wasmtime GitHub notifications bot (Oct 16 2023 at 17:54):

fitzgen submitted PR review:

Nice!

Wasmtime GitHub notifications bot (Oct 16 2023 at 18:42):

fitzgen merged PR #7250.

Last updated: Nov 22 2024 at 16:03 UTC