Stream: git-wasmtime

Topic: wasmtime / PR #7249 cranelift: Add egraph rules for `bswap`

Wasmtime GitHub notifications bot (Oct 16 2023 at 13:49):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #7249.

Wasmtime GitHub notifications bot (Oct 16 2023 at 13:49):

alexcrichton opened PR #7249 from alexcrichton:egraph-bswap to bytecodealliance:main:

WebAssembly doesn't currently have a byte-swapping instruction so this commit pattern matches what LLVM currently generates to simplify to a single bswap instruction in CLIF which can be lowered within each backend to respective native instructions.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 16 2023 at 13:49):

alexcrichton requested cfallin for a review on PR #7249.

Wasmtime GitHub notifications bot (Oct 16 2023 at 17:44):

fitzgen submitted PR review:

r=me with suggestion below

Wasmtime GitHub notifications bot (Oct 16 2023 at 17:44):

fitzgen submitted PR review:

r=me with suggestion below

Wasmtime GitHub notifications bot (Oct 16 2023 at 17:44):

fitzgen created PR review comment:

I think we can also write a wasm -> clif version of this test by not using compile = true. That would be kinda nice since the rule itself is target independent.

Wasmtime GitHub notifications bot (Oct 16 2023 at 17:50):

alexcrichton updated PR #7249.

Wasmtime GitHub notifications bot (Oct 16 2023 at 17:50):

alexcrichton has enabled auto merge for PR #7249.

Wasmtime GitHub notifications bot (Oct 16 2023 at 18:59):

alexcrichton merged PR #7249.

Last updated: Dec 23 2024 at 13:07 UTC