wasmtime / PR #7243 wasi-sockets: Introduce UDP streams · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / PR #7243 wasi-sockets: Introduce UDP streams

Wasmtime GitHub notifications bot (Oct 15 2023 at 08:46):

badeend opened PR #7243 from badeend:udp-streams to bytecodealliance:main:

Introduce new inbound-datagram-stream and outbound-datagram-stream types and moved receive and send methods to those respectively. These streams are returned by bind and can be individually subscribed to. This resolves a design issue where a UDP server would end up in a spin loop because receive returned EWOULDBLOCK but poll_* always returned immediately because the socket was ready for sending. In this new setup, users can poll each direction separately. Fixes https://github.com/WebAssembly/wasi-sockets/issues/64

Additionally

Enable send-like behaviour by making outbound-datagram::remote-address optional. Fixes https://github.com/WebAssembly/wasi-sockets/pull/57

Dropped the network parameter from the connect call, because bind is now _required_ to perform IO.

Wasmtime GitHub notifications bot (Oct 15 2023 at 08:46):

badeend requested alexcrichton for a review on PR #7243.

Wasmtime GitHub notifications bot (Oct 15 2023 at 08:46):

badeend requested wasmtime-core-reviewers for a review on PR #7243.

Wasmtime GitHub notifications bot (Oct 18 2023 at 19:44):

badeend updated PR #7243.

Wasmtime GitHub notifications bot (Oct 20 2023 at 20:11):

badeend updated PR #7243.

Wasmtime GitHub notifications bot (Oct 23 2023 at 20:26):

badeend updated PR #7243.

Wasmtime GitHub notifications bot (Oct 24 2023 at 16:20):

alexcrichton submitted PR review:

Looks great to me, thanks again for this!

Wasmtime GitHub notifications bot (Oct 24 2023 at 19:14):

badeend updated PR #7243.

Wasmtime GitHub notifications bot (Oct 25 2023 at 01:16):

alexcrichton merged PR #7243.

Last updated: Oct 23 2024 at 20:03 UTC