Wasmtime GitHub notifications bot (Oct 14 2023 at 03:50): Wasmtime GitHub notifications bot (Oct 14 2023 at 03:50):alexcrichton requested fitzgen for a review on PR #7242.
Wasmtime GitHub notifications bot (Oct 14 2023 at 03:50):alexcrichton opened PR #7242 from alexcrichton:log-tweaks to bytecodealliance:main:
Some things I noticed from #7239 which are very much not critical but I figure might be nice-to-haves:
- Move the logging configuration to the
wasmtime-cli-flagscrate with the other logging configuration to keep it in one place.- Remove
pretty_env_loggersincetracing-subscriberprobably supplants it.- Don't explicitly inherit env vars in tests since that happens automatically with
Command.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 14 2023 at 03:50):alexcrichton requested wasmtime-core-reviewers for a review on PR #7242.
Wasmtime GitHub notifications bot (Oct 14 2023 at 03:50):alexcrichton requested wasmtime-default-reviewers for a review on PR #7242.
Wasmtime GitHub notifications bot (Oct 16 2023 at 04:30):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Oct 16 2023 at 15:05):alexcrichton merged PR #7242.
Last updated: Oct 23 2024 at 20:03 UTC