alexcrichton requested fitzgen for a review on PR #7242.
alexcrichton opened PR #7242 from alexcrichton:log-tweaks
to bytecodealliance:main
:
Some things I noticed from #7239 which are very much not critical but I figure might be nice-to-haves:
- Move the logging configuration to the
wasmtime-cli-flags
crate with the other logging configuration to keep it in one place.- Remove
pretty_env_logger
sincetracing-subscriber
probably supplants it.- Don't explicitly inherit env vars in tests since that happens automatically with
Command
.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested wasmtime-core-reviewers for a review on PR #7242.
alexcrichton requested wasmtime-default-reviewers for a review on PR #7242.
elliottt submitted PR review.
alexcrichton merged PR #7242.
Last updated: Dec 23 2024 at 12:05 UTC