Stream: git-wasmtime

Topic: wasmtime / PR #7238 c-api/cmake: support disabling ALWAYS...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2023 at 19:10):

rockwotj requested pchickey for a review on PR #7238.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2023 at 19:10):

rockwotj opened PR #7238 from rockwotj:always_build_opt to bytecodealliance:main:

We use a [superbuild pattern][1] (which is a bit outdated but meh) in our CMake Setup. With that pattern, it's nice to be able to disable ALWAYS_BUILD because that causes issues and forces unneeded reconfigures in that setup. Thus add an option to disable ALWAYS_BUILD, in our setup updating the sha or other build variables will properly update wasmtime.

[1]: https://www.kitware.com/cmake-superbuilds-git-submodules/

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2023 at 19:10):

rockwotj requested wasmtime-core-reviewers for a review on PR #7238.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2023 at 19:38):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2023 at 19:38):

pchickey has enabled auto merge for PR #7238.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2023 at 20:21):

pchickey merged PR #7238.

Last updated: Nov 22 2024 at 17:03 UTC