wasmtime / PR #7232 Minor preview2 related test cleanups · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / PR #7232 Minor preview2 related test cleanups

Wasmtime GitHub notifications bot (Oct 12 2023 at 19:28):

pchickey opened PR #7232 from bytecodealliance:pch/minor_test_cleanups to bytecodealliance:main:

there was a duplicate test for the behavior of panics

the test for stream pollable children lifetimes was different than all of the others to invoke, so split it into two tests (in preview2 instead of cli) and assert that one of them traps, the other succceeds

Wasmtime GitHub notifications bot (Oct 12 2023 at 19:28):

pchickey requested fitzgen for a review on PR #7232.

Wasmtime GitHub notifications bot (Oct 12 2023 at 19:28):

pchickey requested wasmtime-core-reviewers for a review on PR #7232.

Wasmtime GitHub notifications bot (Oct 12 2023 at 19:30):

pchickey requested elliottt for a review on PR #7232.

Wasmtime GitHub notifications bot (Oct 12 2023 at 20:32):

elliottt submitted PR review:

Nice!

Wasmtime GitHub notifications bot (Oct 12 2023 at 21:22):

pchickey merged PR #7232.

Last updated: Dec 23 2024 at 13:07 UTC