Wasmtime GitHub notifications bot (Oct 06 2023 at 16:56): Wasmtime GitHub notifications bot (Oct 06 2023 at 16:56):alexcrichton opened PR #7172 from alexcrichton:bindgen-multiversion to bytecodealliance:main:
This commit fixes a bug in the
bindgen!macro where when faced with multiple packages that differ only in version number invalid bindings were generated. The fix here is to add version number information to package module names if necessary in situations such as this. This required some refactoring internally to have a single source of truth for what the name of a module should be and avoid having it implicitly calculated in two locations.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 06 2023 at 16:56):alexcrichton requested fitzgen for a review on PR #7172.
Wasmtime GitHub notifications bot (Oct 06 2023 at 16:56):alexcrichton requested wasmtime-core-reviewers for a review on PR #7172.
Wasmtime GitHub notifications bot (Oct 06 2023 at 20:06):fitzgen requested elliottt for a review on PR #7172.
Wasmtime GitHub notifications bot (Oct 06 2023 at 21:17):elliottt submitted PR review:
I think this all makes sense! I had one suggestion about the changes to the
InterfaceNametype, but it's not a blocker.
Wasmtime GitHub notifications bot (Oct 06 2023 at 21:17):elliottt submitted PR review:
I think this all makes sense! I had one suggestion about the changes to the
InterfaceNametype, but it's not a blocker.
Wasmtime GitHub notifications bot (Oct 06 2023 at 21:17):elliottt created PR review comment:
It looks like this vector only ever has one or three strings in it, would it make sense to make a more precise type that names those cases?
Wasmtime GitHub notifications bot (Oct 06 2023 at 23:00):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Oct 06 2023 at 23:00):alexcrichton created PR review comment:
I think that's probably a bit overkill on types for now since nothing uses this as anything other than
.join("::")currently, but if that changes in the future I think it'd be reasonable to add yeah
Wasmtime GitHub notifications bot (Oct 06 2023 at 23:45):alexcrichton merged PR #7172.
Last updated: Nov 22 2024 at 16:03 UTC