Stream: git-wasmtime

Topic: wasmtime / PR #7166 add i128 support for iabs on x86_64


view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2023 at 01:11):

p3achyjr opened PR #7166 from p3achyjr:main to bytecodealliance:main:

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Per https://github.com/bytecodealliance/wasmtime/issues/5466, we do not have i128 support for iabs on either aarch64 or x86_64. This PR adds support for x86.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2023 at 01:11):

p3achyjr requested cfallin for a review on PR #7166.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2023 at 01:11):

p3achyjr requested wasmtime-compiler-reviewers for a review on PR #7166.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2023 at 01:15):

p3achyjr updated PR #7166.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2023 at 01:24):

p3achyjr updated PR #7166.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2023 at 03:08):

cfallin submitted PR review:

LGTM -- thanks a bunch for this!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2023 at 03:58):

cfallin merged PR #7166.


Last updated: Oct 23 2024 at 20:03 UTC