Wasmtime GitHub notifications bot (Oct 05 2023 at 16:56): Wasmtime GitHub notifications bot (Oct 05 2023 at 16:56):elliottt opened PR #7161 from elliottt:trevor/wasi-http-borrow to bytecodealliance:main:
When I updated wasi-http to use resources, I neglected to add
borrowannotations for borrowed values. This mostly worked out as we had only annotated borrows with comments in two places, one of which was not actually a borrow in the implementation. This PR fixes this omission, and corrects the buggy constructor foroutgoing-response.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 05 2023 at 16:56):elliottt requested wasmtime-core-reviewers for a review on PR #7161.
Wasmtime GitHub notifications bot (Oct 05 2023 at 16:56):elliottt requested alexcrichton for a review on PR #7161.
Wasmtime GitHub notifications bot (Oct 05 2023 at 18:44):elliottt edited PR #7161:
When I updated wasi-http to use resources, I neglected to add
borrowannotations for borrowed values. This mostly worked out as we had only annotated borrows with comments in two places, one of which was not actually a borrow in the implementation. This PR fixes this omission, and corrects the buggy constructor foroutgoing-response.We'll need to backport this change to the 14.0.0 release branch, as the version of wasi-http with resources had merged before the branch was made.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 05 2023 at 18:50):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Oct 05 2023 at 19:57):alexcrichton merged PR #7161.
Last updated: Dec 23 2024 at 13:07 UTC