Stream: git-wasmtime

Topic: wasmtime / PR #7159 Add a whole lot of semicolons to WIT ...

Wasmtime GitHub notifications bot (Oct 05 2023 at 15:57):

alexcrichton opened PR #7159 from alexcrichton:wit-semicolons to bytecodealliance:main:

To prepare this commit I've run WIT_REQUIRE_SEMICOLONS=1 ./ci/run-tests.sh locally which configures wit-parser to generate an error for missing semicolons in WIT files. This led me to add quite a few semicolons in quite a few places in what is going to be the first of a few batches of semicolons.

CI checks for this cannot be added just yet because the wasi-nn spec is a submodule which needs to be updated with semicolons before this repository can require semicolons. Nevertheless that doesn't stop us from using semicolons in the meantime (yay gradual rollout of changes!) so I figure this would be good to get in sooner rather than later.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 05 2023 at 15:57):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7159.

Wasmtime GitHub notifications bot (Oct 05 2023 at 15:57):

alexcrichton requested fitzgen for a review on PR #7159.

Wasmtime GitHub notifications bot (Oct 05 2023 at 21:18):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Oct 05 2023 at 22:44):

alexcrichton updated PR #7159.

Wasmtime GitHub notifications bot (Oct 05 2023 at 22:46):

alexcrichton has enabled auto merge for PR #7159.

Wasmtime GitHub notifications bot (Oct 06 2023 at 13:39):

alexcrichton updated PR #7159.

Wasmtime GitHub notifications bot (Oct 06 2023 at 13:39):

alexcrichton has enabled auto merge for PR #7159.

Wasmtime GitHub notifications bot (Oct 06 2023 at 14:55):

alexcrichton merged PR #7159.

Last updated: Dec 23 2024 at 12:05 UTC