Stream: git-wasmtime

Topic: wasmtime / PR #7156 riscv64: Move `sextend` optimizations...

Wasmtime GitHub notifications bot (Oct 05 2023 at 01:33):

alexcrichton opened PR #7156 from alexcrichton:rv64-sext-zext to bytecodealliance:main:

This commit moves the optimizations from sextend for various shapes of instructions into the sext helper. This enables these optimizations to kick in when generating other instructions which require sign-extensions such as icmp and brif.

This additionally fixes an issue introduced in #7121 where uextend-of-sextend wasn't translated correctly and the outer uextend was mistakenly omitted.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 05 2023 at 01:33):

alexcrichton requested afonso360 for a review on PR #7156.

Wasmtime GitHub notifications bot (Oct 05 2023 at 01:33):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #7156.

Wasmtime GitHub notifications bot (Oct 05 2023 at 01:33):

alexcrichton requested abrown for a review on PR #7156.

Wasmtime GitHub notifications bot (Oct 05 2023 at 14:56):

afonso360 submitted PR review:

Makes sense to me. :+1:

Wasmtime GitHub notifications bot (Oct 05 2023 at 15:45):

afonso360 merged PR #7156.

Last updated: Nov 22 2024 at 17:03 UTC