Stream: git-wasmtime

Topic: wasmtime / PR #7152 Add an error resource to WASI streams

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 22:20):

alexcrichton opened PR #7152 from alexcrichton:wasi-stream-error-information to bytecodealliance:main:

This commit adds a new error resource to the wasi:io/streams
interface. This error resource is returned as part of
last-operation-failed and serves as a means to discover through other
interfaces more granular type information than a generic string. This
error type has a new function in the filesystem interface, for
example, which enables getting filesystem-related error codes from I/O
performed on filesystem-originating streams. This is plumbed through to
the adapter as well to return more than ERRNO_IO from failed
read/write operations now too.

This is not super fancy just yet but is intended to be a vector through
which future additions can be done. The main thing this enables is to
avoid dropping errors on the floor in the host and enabling the guest to
discover further information about I/O errors on streams.

Closes https://github.com/bytecodealliance/wasmtime/issues/7017

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 22:20):

alexcrichton requested elliottt for a review on PR #7152.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 22:20):

alexcrichton requested fitzgen for a review on PR #7152.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 22:20):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7152.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2023 at 17:09):

elliottt submitted PR review:

This looks great!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2023 at 17:09):

elliottt submitted PR review:

This looks great!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2023 at 17:09):

elliottt created PR review comment:

The syntax for naming resources in with turned this into demo:pkg/a/b, would it make the sense to do the same here?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2023 at 17:09):

elliottt created PR review comment:

    /// `stream-error` values are returned whenever an

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2023 at 19:10):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2023 at 19:10):

alexcrichton created PR review comment:

Agreed! I'll do this in a follow up as I'd also like to change "...": Type to "..." => Type

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2023 at 19:10):

alexcrichton updated PR #7152.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2023 at 19:10):

alexcrichton has enabled auto merge for PR #7152.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2023 at 19:23):

alexcrichton updated PR #7152.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2023 at 22:40):

alexcrichton updated PR #7152.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2023 at 22:41):

alexcrichton has enabled auto merge for PR #7152.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2023 at 23:54):

alexcrichton merged PR #7152.

Last updated: Nov 22 2024 at 16:03 UTC