Stream: git-wasmtime

Topic: wasmtime / PR #7151 riscv64: Ignore extends for `fcmp`

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 22:04):

afonso360 opened PR #7151 from afonso360:riscv-make-fcmp-extended to bytecodealliance:main:

:wave: Hey,

This is a small follow up to #7121. fcmp only ever returns 0 or 1, so that means that we can safely ignore extends from the output of that instruction.

The other instructions that I pointed out in that comment end up already being covered by the remaining rules. Only fcmp was missing.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 22:04):

afonso360 requested cfallin for a review on PR #7151.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 22:04):

afonso360 requested wasmtime-compiler-reviewers for a review on PR #7151.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 22:16):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 22:16):

cfallin has enabled auto merge for PR #7151.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 23:33):

cfallin merged PR #7151.

Last updated: Oct 23 2024 at 20:03 UTC