Stream: git-wasmtime

Topic: wasmtime / PR #7146 riscv64: Add support for `min` and `m...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 10:32):

afonso360 opened PR #7146 from afonso360:riscv-zbb-min-max to bytecodealliance:main:

:wave: Hey,

This PR is a follow up to #7145 and adds suport for the min{,u} and max{,u} instructions available in the Zbb extension. We had these implemented in our emit layer, but they were never used in ISLE. Only max as part of the iabs lowering.

These instructions are now implemented in gen_select_xreg where they have a greater chance of being selected.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 10:32):

afonso360 requested fitzgen for a review on PR #7146.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 10:32):

afonso360 requested wasmtime-compiler-reviewers for a review on PR #7146.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 16:26):

alexcrichton submitted PR review:

Nice!

Oddly enough I was also poking at this last night, but I like how it fits well into gen_select_xreg here. :+1:

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 22:05):

afonso360 updated PR #7146.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 22:07):

afonso360 has enabled auto merge for PR #7146.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 23:29):

afonso360 merged PR #7146.

Last updated: Dec 06 2025 at 06:05 UTC