Wasmtime GitHub notifications bot (Oct 03 2023 at 19:00): Wasmtime GitHub notifications bot (Oct 03 2023 at 19:00):alexcrichton opened PR #7143 from alexcrichton:fix-flaky-http-tests to bytecodealliance:main:
This commit refactors the wasi-http tests we have in this repository with a few changes:
Each test now uses a dedicated port for the test. The port 0 is bound and whatever the OS gives is used for the duration of the test. This prevents tests from possibly interfering with each other.
Server spawning is abstracted behind a single
Servertype now which internally has http1/2 constructors.Timeouts for server shutdown are removed since they were failing in CI and are likely best handled for each test individually if necessary.
As a minor cleanup the
tokiousage in guest programs was removed as it was boilerplate in this case. This shouldn't affect the runtimes of tests, however.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 03 2023 at 19:00):alexcrichton requested elliottt for a review on PR #7143.
Wasmtime GitHub notifications bot (Oct 03 2023 at 19:00):alexcrichton requested fitzgen for a review on PR #7143.
Wasmtime GitHub notifications bot (Oct 03 2023 at 19:01):alexcrichton requested wasmtime-core-reviewers for a review on PR #7143.
Wasmtime GitHub notifications bot (Oct 03 2023 at 19:01):alexcrichton requested wasmtime-default-reviewers for a review on PR #7143.
Wasmtime GitHub notifications bot (Oct 03 2023 at 19:10):alexcrichton updated PR #7143.
Wasmtime GitHub notifications bot (Oct 03 2023 at 20:40):elliottt submitted PR review:
This is awesome, thank you!
Wasmtime GitHub notifications bot (Oct 04 2023 at 14:44):alexcrichton updated PR #7143.
Wasmtime GitHub notifications bot (Oct 04 2023 at 16:10):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #7143.
Wasmtime GitHub notifications bot (Oct 04 2023 at 16:10):alexcrichton updated PR #7143.
Wasmtime GitHub notifications bot (Oct 04 2023 at 16:15):alexcrichton updated PR #7143.
Wasmtime GitHub notifications bot (Oct 04 2023 at 16:19):alexcrichton has enabled auto merge for PR #7143.
Wasmtime GitHub notifications bot (Oct 04 2023 at 17:16):alexcrichton updated PR #7143.
Wasmtime GitHub notifications bot (Oct 04 2023 at 18:54):alexcrichton merged PR #7143.
Last updated: Dec 23 2024 at 13:07 UTC