Stream: git-wasmtime

Topic: wasmtime / PR #7142 riscv64: Refactor and simplify some b...

Wasmtime GitHub notifications bot (Oct 03 2023 at 17:00):

alexcrichton requested afonso360 for a review on PR #7142.

Wasmtime GitHub notifications bot (Oct 03 2023 at 17:00):

alexcrichton opened PR #7142 from alexcrichton:rv64-refactor-branches-and-fcmp to bytecodealliance:main:

This commit is aimed at simplifying the layers necessary to generate a
branch for a brif statement. Previously this involved a
lower_cond_br helper which bottomed out in emitting a CondBr
instruction. The intention here was to cut all that out and emit a
CondBr directly.

Along the way I've additionally taken the liberty of simplifying fcmp
as well. This moves the "prefer ordered compares" logic into emit_fcmp
so it can benefit the fcmp instruction as well. This additionally
trimmed some abstractions around branches which shouldn't be necessary
any longer.

Wasmtime GitHub notifications bot (Oct 03 2023 at 17:00):

alexcrichton requested cfallin for a review on PR #7142.

Wasmtime GitHub notifications bot (Oct 03 2023 at 17:00):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #7142.

Wasmtime GitHub notifications bot (Oct 03 2023 at 17:00):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #7142.

Wasmtime GitHub notifications bot (Oct 03 2023 at 17:00):

alexcrichton requested elliottt for a review on PR #7142.

Wasmtime GitHub notifications bot (Oct 03 2023 at 17:09):

cfallin submitted PR review:

All the lowerings look correct to me!

Wasmtime GitHub notifications bot (Oct 03 2023 at 17:17):

alexcrichton has enabled auto merge for PR #7142.

Wasmtime GitHub notifications bot (Oct 03 2023 at 21:28):

alexcrichton merged PR #7142.

Last updated: Dec 23 2024 at 13:07 UTC