Stream: git-wasmtime

Topic: wasmtime / PR #7139 riscv64: Further optimize constants l...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 03 2023 at 14:42):

a1phyr opened PR #7139 from a1phyr:improve_riscv_constants to bytecodealliance:main:

Follow-up of #7131

In some cases we can avoid an addi by using lui and shifting less

view this post on Zulip Wasmtime GitHub notifications bot (Oct 03 2023 at 14:42):

a1phyr requested abrown for a review on PR #7139.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 03 2023 at 14:42):

a1phyr requested wasmtime-compiler-reviewers for a review on PR #7139.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 03 2023 at 14:56):

alexcrichton submitted PR review:

Thanks for this! Would you be up for updating the rule added in https://github.com/bytecodealliance/wasmtime/pull/7131 as well to match this rule in terms of consistency? I tried to put everything in ISLE in that PR but I like how this PR turned out as well so that may not have been the best option.

I was initially quite perplexed as I thought that this should have already been handled by https://github.com/bytecodealliance/wasmtime/pull/7131 and the "aha!" moment was realizing that there has to be at least 12 trailing zeros since the immediate starts at higher bits. I think being able to see that difference in ISLE might be kind of nice.

No worries either way though, this is a nice improvement, so thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 03 2023 at 15:38):

a1phyr updated PR #7139.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 03 2023 at 16:11):

a1phyr updated PR #7139.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 03 2023 at 16:24):

alexcrichton submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 03 2023 at 16:24):

alexcrichton has enabled auto merge for PR #7139.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 07:42):

alexcrichton has disabled auto merge for PR #7139.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 07:42):

a1phyr updated PR #7139.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 12:21):

a1phyr updated PR #7139.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 13:09):

a1phyr requested alexcrichton for a review on PR #7139.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 15:23):

alexcrichton merged PR #7139.

Last updated: Nov 22 2024 at 17:03 UTC