a1phyr opened PR #7139 from a1phyr:improve_riscv_constants
to bytecodealliance:main
:
Follow-up of #7131
In some cases we can avoid an
addi
by usinglui
and shifting less
a1phyr requested abrown for a review on PR #7139.
a1phyr requested wasmtime-compiler-reviewers for a review on PR #7139.
alexcrichton submitted PR review:
Thanks for this! Would you be up for updating the rule added in https://github.com/bytecodealliance/wasmtime/pull/7131 as well to match this rule in terms of consistency? I tried to put everything in ISLE in that PR but I like how this PR turned out as well so that may not have been the best option.
I was initially quite perplexed as I thought that this should have already been handled by https://github.com/bytecodealliance/wasmtime/pull/7131 and the "aha!" moment was realizing that there has to be at least 12 trailing zeros since the immediate starts at higher bits. I think being able to see that difference in ISLE might be kind of nice.
No worries either way though, this is a nice improvement, so thanks!
a1phyr updated PR #7139.
a1phyr updated PR #7139.
alexcrichton submitted PR review:
Thanks!
alexcrichton has enabled auto merge for PR #7139.
alexcrichton has disabled auto merge for PR #7139.
a1phyr updated PR #7139.
a1phyr updated PR #7139.
a1phyr requested alexcrichton for a review on PR #7139.
alexcrichton merged PR #7139.
Last updated: Dec 23 2024 at 13:07 UTC