Stream: git-wasmtime

Topic: wasmtime / PR #7138 Fix a flaky preview2 test

Wasmtime GitHub notifications bot (Oct 03 2023 at 14:29):

alexcrichton opened PR #7138 from alexcrichton:fix-flaky-test to bytecodealliance:main:

Found in CI for #7099 this commit updates the durations used in the resolves_immediately and never_resolves tests. For immediately resolving it should be ok to wait for a generous amount of time since the timeout is only a protection against tests hanging. For never_resolves it should be ok to wait a short amount of time and any failure there will show up as a spurious failure.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 03 2023 at 14:29):

alexcrichton requested fitzgen for a review on PR #7138.

Wasmtime GitHub notifications bot (Oct 03 2023 at 14:29):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7138.

Wasmtime GitHub notifications bot (Oct 03 2023 at 16:20):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Oct 03 2023 at 19:11):

alexcrichton merged PR #7138.

Last updated: Dec 23 2024 at 12:05 UTC