Stream: git-wasmtime

Topic: wasmtime / PR #7135 wasi-http: Use resources in wasi-http

Wasmtime GitHub notifications bot (Oct 03 2023 at 00:47):

elliottt opened PR #7135 from elliottt:trevor/wasi-http-resources to bytecodealliance:main:

Migrate wasi-http over to resources, now that they've landed on main.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 03 2023 at 01:10):

elliottt updated PR #7135.

Wasmtime GitHub notifications bot (Oct 03 2023 at 01:29):

elliottt updated PR #7135.

Wasmtime GitHub notifications bot (Oct 03 2023 at 01:33):

elliottt updated PR #7135.

Wasmtime GitHub notifications bot (Oct 03 2023 at 17:38):

elliottt updated PR #7135.

Wasmtime GitHub notifications bot (Oct 03 2023 at 17:41):

elliottt updated PR #7135.

Wasmtime GitHub notifications bot (Oct 03 2023 at 17:56):

elliottt edited PR #7135:

Migrate wasi-http over to resources, now that they've landed on main.

This was a pretty straight-forward refactoring: I replaced all of the u32 alias types for the pseudo-resources in the spec with actual resources. Using resources led to the complete removal of the TableHttpExt trait, and also the TableLens machinery that I had added earlier.

One decision that I made here was to add static functions for the functions that we have that consume resources. These could have instead been functions not defined on the resource, but I liked being able to use a simple name like finish that was scoped to the resource rather than prefix it to make it unique.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 03 2023 at 18:47):

elliottt updated PR #7135.

Wasmtime GitHub notifications bot (Oct 03 2023 at 18:47):

elliottt has marked PR #7135 as ready for review.

Wasmtime GitHub notifications bot (Oct 03 2023 at 18:47):

elliottt requested fitzgen for a review on PR #7135.

Wasmtime GitHub notifications bot (Oct 03 2023 at 18:47):

elliottt requested wasmtime-core-reviewers for a review on PR #7135.

Wasmtime GitHub notifications bot (Oct 03 2023 at 18:47):

elliottt requested alexcrichton for a review on PR #7135.

Wasmtime GitHub notifications bot (Oct 03 2023 at 18:47):

elliottt requested sunfishcode for a review on PR #7135.

Wasmtime GitHub notifications bot (Oct 03 2023 at 18:49):

elliottt updated PR #7135.

Wasmtime GitHub notifications bot (Oct 03 2023 at 19:38):

alexcrichton submitted PR review:

:+1:

Wasmtime GitHub notifications bot (Oct 03 2023 at 21:28):

alexcrichton merged PR #7135.

Last updated: Dec 23 2024 at 12:05 UTC