Stream: git-wasmtime

Topic: wasmtime / PR #7134 wasmtime: Handle common cli args in `...

Wasmtime GitHub notifications bot (Oct 02 2023 at 22:42):

elliottt opened PR #7134 from elliottt:trevor/serve-args to bytecodealliance:main:

Generalize some of the command-line handling between the serve and run commands, and refactor serve to process the arguments it was ignoring before.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 03 2023 at 21:06):

elliottt updated PR #7134.

Wasmtime GitHub notifications bot (Oct 03 2023 at 21:37):

elliottt updated PR #7134.

Wasmtime GitHub notifications bot (Oct 03 2023 at 21:52):

elliottt updated PR #7134.

Wasmtime GitHub notifications bot (Oct 03 2023 at 22:16):

elliottt updated PR #7134.

Wasmtime GitHub notifications bot (Oct 03 2023 at 22:18):

elliottt updated PR #7134.

Wasmtime GitHub notifications bot (Oct 03 2023 at 23:50):

elliottt updated PR #7134.

Wasmtime GitHub notifications bot (Oct 04 2023 at 00:00):

elliottt updated PR #7134.

Wasmtime GitHub notifications bot (Oct 04 2023 at 00:04):

elliottt has marked PR #7134 as ready for review.

Wasmtime GitHub notifications bot (Oct 04 2023 at 00:04):

elliottt requested alexcrichton for a review on PR #7134.

Wasmtime GitHub notifications bot (Oct 04 2023 at 00:04):

elliottt requested wasmtime-core-reviewers for a review on PR #7134.

Wasmtime GitHub notifications bot (Oct 04 2023 at 00:05):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Oct 04 2023 at 00:05):

elliottt created PR review comment:

Viceroy spawns a thread for this, is it reasonable to use a tokio task instead?

Wasmtime GitHub notifications bot (Oct 04 2023 at 01:55):

elliottt updated PR #7134.

Wasmtime GitHub notifications bot (Oct 04 2023 at 03:00):

elliottt updated PR #7134.

Wasmtime GitHub notifications bot (Oct 04 2023 at 14:23):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 04 2023 at 14:23):

alexcrichton created PR review comment:

No I think this is best done as a thread because if you've got N cores each running wasm within Tokio then because nothing is preemptive a separate Tokio task wouldn't ever actually run to increment the epoch, so OS scheduling is required to guarantee epochs get incremented and Tokio tasks yield

Wasmtime GitHub notifications bot (Oct 04 2023 at 14:25):

alexcrichton submitted PR review:

Thanks! If you're interested the WASI configuration stuff would also be a good candidate for src/common.rs because the arguments like -S live within the cli-flags crate but they're not actually processed there. I think this is good to merge either way though!

(similarly handling --allow-precompiled and loading a module to run might be good to put in src/common.rs as well)

Wasmtime GitHub notifications bot (Oct 04 2023 at 17:51):

elliottt updated PR #7134.

Wasmtime GitHub notifications bot (Oct 04 2023 at 18:50):

elliottt updated PR #7134.

Wasmtime GitHub notifications bot (Oct 04 2023 at 19:02):

elliottt has enabled auto merge for PR #7134.

Wasmtime GitHub notifications bot (Oct 04 2023 at 20:05):

elliottt merged PR #7134.

Last updated: Dec 23 2024 at 12:05 UTC