Stream: git-wasmtime

Topic: wasmtime / PR #7133 Handle `lower_branch` consistently am...

Wasmtime GitHub notifications bot (Oct 02 2023 at 21:56):

alexcrichton opened PR #7133 from alexcrichton:clif-refactor-branches to bytecodealliance:main:

This commit is a refactoring to consistently implement lower_branch among Cranelift's backends. Previously each backend had its own means of extracting labels and shuffling along information, and now there's prelude methods for all backends to access and use. This changes a few display impls but the actual meat of what's emitted shouldn't change amongst the backends.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 02 2023 at 21:56):

alexcrichton requested fitzgen for a review on PR #7133.

Wasmtime GitHub notifications bot (Oct 02 2023 at 21:56):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #7133.

Wasmtime GitHub notifications bot (Oct 02 2023 at 22:44):

alexcrichton updated PR #7133.

Wasmtime GitHub notifications bot (Oct 03 2023 at 16:05):

fitzgen submitted PR review:

LGTM; question below.

Wasmtime GitHub notifications bot (Oct 03 2023 at 16:05):

fitzgen submitted PR review:

LGTM; question below.

Wasmtime GitHub notifications bot (Oct 03 2023 at 16:05):

fitzgen created PR review comment:

What happened to label3?

Wasmtime GitHub notifications bot (Oct 03 2023 at 16:09):

alexcrichton created PR review comment:

Previously all jump targets, plus the default, was stored in a list where the first element of the list was implicitly the default. Now they're stored separately, the default in one location and the targets in another. This display impl I left rendering only the targets as those are the jump table entries.

Wasmtime GitHub notifications bot (Oct 03 2023 at 16:09):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 03 2023 at 16:58):

alexcrichton merged PR #7133.

Last updated: Dec 23 2024 at 12:05 UTC