Stream: git-wasmtime

Topic: wasmtime / PR #7132 riscv64: Optimize `uadd_overflow_trap...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2023 at 20:29):

alexcrichton requested afonso360 for a review on PR #7132.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2023 at 20:29):

alexcrichton opened PR #7132 from alexcrichton:rv64-refactor-uadd-overflow-trap to bytecodealliance:main:

This commit removes the usage of gen_icmp in uadd_overflow_trap. The comparison previously done with an explicit comparison is now bundled directly into the conditional branch to go to the trap itself.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2023 at 20:29):

alexcrichton requested abrown for a review on PR #7132.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2023 at 20:29):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #7132.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2023 at 21:23):

afonso360 submitted PR review:

Nice!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2023 at 22:24):

afonso360 merged PR #7132.


Last updated: Dec 23 2024 at 13:07 UTC