Wasmtime GitHub notifications bot (Oct 02 2023 at 20:29): Wasmtime GitHub notifications bot (Oct 02 2023 at 20:29):alexcrichton requested afonso360 for a review on PR #7132.
Wasmtime GitHub notifications bot (Oct 02 2023 at 20:29):alexcrichton opened PR #7132 from alexcrichton:rv64-refactor-uadd-overflow-trap to bytecodealliance:main:
This commit removes the usage of
gen_icmpinuadd_overflow_trap. The comparison previously done with an explicit comparison is now bundled directly into the conditional branch to go to the trap itself.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 02 2023 at 20:29):alexcrichton requested abrown for a review on PR #7132.
Wasmtime GitHub notifications bot (Oct 02 2023 at 20:29):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #7132.
Wasmtime GitHub notifications bot (Oct 02 2023 at 21:23):afonso360 submitted PR review:
Nice!
Wasmtime GitHub notifications bot (Oct 02 2023 at 22:24):afonso360 merged PR #7132.
Last updated: Nov 22 2024 at 16:03 UTC