Stream: git-wasmtime

Topic: wasmtime / PR #7128 Fix compatibility with Rust 1.70.0


view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2023 at 16:18):

alexcrichton opened PR #7128 from alexcrichton:fix-windows-msrv to bytecodealliance:main:

This commit fixes a compatibility issue with Rust 1.70.0 on Windows targets. Rust 1.71.0 stabilized AsSocket for Arc<T> which is used here implicitly, so to compile successfully on 1.70.0, our current MSRV, a slight code change is required.

Closes #7127

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2023 at 16:19):

alexcrichton requested fitzgen for a review on PR #7128.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2023 at 16:19):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7128.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2023 at 16:25):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2023 at 16:29):

alexcrichton has enabled auto merge for PR #7128.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2023 at 17:21):

sunfishcode submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2023 at 17:36):

alexcrichton merged PR #7128.


Last updated: Dec 23 2024 at 12:05 UTC