Stream: git-wasmtime

Topic: wasmtime / PR #7120 wasi-sockets: Simplify & clarify TCP ...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 01 2023 at 08:05):

badeend opened PR #7120 from badeend:tcp-error-checking to bytecodealliance:main:

    POSIX mentions:
    > If connect() fails, the state of the socket is unspecified. Conforming applications should
    > close the file descriptor and create a new socket before attempting to reconnect.

    WASI prescribes the following behavior:
    - If `connect` fails because an input/state validation error, the socket should remain usable.
    - If a connection was actually attempted but failed, the socket should become unusable for further network communication.
POSIX mentions:
> If the socket has not been bound to a local name, the value
> stored in the object pointed to by `address` is unspecified.

WASI is stricter and requires `local-address` to return `not-bound` when the socket hasn't been bound yet.

Additionally

view this post on Zulip Wasmtime GitHub notifications bot (Oct 01 2023 at 08:05):

badeend requested wasmtime-core-reviewers for a review on PR #7120.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 01 2023 at 08:05):

badeend requested pchickey for a review on PR #7120.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 01 2023 at 08:11):

badeend updated PR #7120.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2023 at 18:24):

badeend updated PR #7120.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2023 at 22:55):

pchickey requested alexcrichton for a review on PR #7120.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 16:04):

badeend updated PR #7120.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2023 at 16:16):

badeend updated PR #7120.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2023 at 07:41):

badeend updated PR #7120.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2023 at 19:20):

badeend updated PR #7120.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 07 2023 at 09:36):

badeend updated PR #7120.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2023 at 10:10):

badeend updated PR #7120.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2023 at 10:11):

badeend edited PR #7120:

    POSIX mentions:
    > If connect() fails, the state of the socket is unspecified. Conforming applications should
    > close the file descriptor and create a new socket before attempting to reconnect.

    WASI prescribes the following behavior:
    - If `connect` fails because an input/state validation error, the socket should remain usable.
    - If a connection was actually attempted but failed, the socket should become unusable for further network communication.
POSIX mentions:
> If the socket has not been bound to a local name, the value
> stored in the object pointed to by `address` is unspecified.

WASI is stricter and requires `local-address` to return `not-bound` when the socket hasn't been bound yet.

Additionally

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2023 at 10:13):

badeend edited PR #7120:

    POSIX mentions:
    > If connect() fails, the state of the socket is unspecified. Conforming applications should
    > close the file descriptor and create a new socket before attempting to reconnect.

    WASI prescribes the following behavior:
    - If `connect` fails because an input/state validation error, the socket should remain usable.
    - If a connection was actually attempted but failed, the socket should become unusable for further network communication.
POSIX mentions:
> If the socket has not been bound to a local name, the value
> stored in the object pointed to by `address` is unspecified.

WASI is stricter and requires `local-address` to return `not-bound` when the socket hasn't been bound yet.

Additionally

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2023 at 10:50):

badeend updated PR #7120.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2023 at 12:41):

badeend updated PR #7120.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2023 at 13:15):

badeend updated PR #7120.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2023 at 03:22):

alexcrichton submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2023 at 04:38):

alexcrichton merged PR #7120.


Last updated: Dec 23 2024 at 12:05 UTC