Stream: git-wasmtime

Topic: wasmtime / PR #7118 Remove `Table*Ext` traits for preview2

Wasmtime GitHub notifications bot (Sep 29 2023 at 21:57):

alexcrichton opened PR #7118 from alexcrichton:typed-table to bytecodealliance:main:

With the usage of resources and some small additions to the Table type we can get all the benefit of type-safety here without the boilerplates of traits, yay Resource<T> starting to pay for itself!

I've done light refactorings here while I was at it:

• Much of preview2-to-preview1 needed restructuring as I opted to use Resource<T> rather than the prior u32.
• Blocking functions on streams now check ready() and then call the non-blocking version. (avoids duplication)
• All pollable resources are now tracked automatically as children of the resource from whence they came, causing a dynamic error if the original item is destroyed before the pollable

Wasmtime GitHub notifications bot (Sep 29 2023 at 21:57):

alexcrichton requested fitzgen for a review on PR #7118.

Wasmtime GitHub notifications bot (Sep 29 2023 at 21:57):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7118.

Wasmtime GitHub notifications bot (Sep 29 2023 at 22:03):

alexcrichton updated PR #7118.

Wasmtime GitHub notifications bot (Sep 29 2023 at 22:08):

alexcrichton updated PR #7118.

Wasmtime GitHub notifications bot (Sep 29 2023 at 23:32):

pchickey submitted PR review:

:rocket: type safety :rocket:

Wasmtime GitHub notifications bot (Sep 29 2023 at 23:32):

elliottt submitted PR review:

:fire:

Wasmtime GitHub notifications bot (Sep 30 2023 at 00:23):

pchickey merged PR #7118.

Last updated: Nov 22 2024 at 16:03 UTC