Stream: git-wasmtime

Topic: wasmtime / PR #7112 c-api: Update reexport of wasmtime cr...

Wasmtime GitHub notifications bot (Sep 29 2023 at 22:23):

alexcrichton edited PR #7112:

This is a follow-up to #6765 to remove this reexport since it was originally added to use both the C API and the wasmtime crate in the same downstream crate, but this should be possible through Cargo with:

[dependencies]
wasmtime = "13"
wasmtime-c-api = { version = "13", package = "wasmtime-c-api" }

and that way wasmtime::* is available as well as wasmtime_c_api::*

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 29 2023 at 22:24):

alexcrichton edited PR #7112:

This is a follow-up to #6765 to update this reexport since it was originally added to use both the C API and the wasmtime crate in the same downstream crate, but this should be possible through Cargo with:

[dependencies]
wasmtime = "13"
wasmtime-c-api = { version = "13", package = "wasmtime-c-api" }

and that way wasmtime::* is available as well as wasmtime_c_api::*. For convenience though the name wasmtime is still exported to allow depending on just this crate.

Wasmtime GitHub notifications bot (Sep 29 2023 at 22:24):

alexcrichton has marked PR #7112 as ready for review.

Wasmtime GitHub notifications bot (Sep 29 2023 at 22:24):

alexcrichton requested pchickey for a review on PR #7112.

Wasmtime GitHub notifications bot (Sep 29 2023 at 22:24):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7112.

Wasmtime GitHub notifications bot (Oct 03 2023 at 14:34):

alexcrichton requested fitzgen for a review on PR #7112.

Wasmtime GitHub notifications bot (Oct 18 2023 at 20:57):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Oct 18 2023 at 21:45):

fitzgen merged PR #7112.

Last updated: Nov 22 2024 at 16:03 UTC