Stream: git-wasmtime

Topic: wasmtime / PR #7109 Implement the `wasi:sockets/ip-name-...

Wasmtime GitHub notifications bot (Sep 28 2023 at 22:51):

alexcrichton opened PR #7109 from alexcrichton:wasi-ip-name-lookup to bytecodealliance:main:

This commit is an initial implementation of the new ip-name-lookup
interface from the wasi-sockets proposal. The intention is to get a
sketch of what an implementation would look like for the preview2
release later this year. Notable features of this implementation are:

• Name lookups are disabled by default and must be explicitly enabled in
  WasiCtx. This seems like a reasonable default for now while the full
  set of configuration around this is settled.

• I've added new "typed" methods to preview2::Table to avoid the need
  for extra helpers when using resources.

• A new -Sallow-ip-name-lookup option is added to control this on the
  CLI.

• Implementation-wise this uses the blocking resolution in the Rust
  standard library, built on getaddrinfo. This doesn't invoke
  getaddrinfo "raw", however, so information such as error details can
  be lost in translation. This will probably need to change in the
  future.

Closes https://github.com/bytecodealliance/wasmtime/issues/7070

Wasmtime GitHub notifications bot (Sep 29 2023 at 20:09):

alexcrichton updated PR #7109.

Wasmtime GitHub notifications bot (Sep 30 2023 at 00:24):

alexcrichton has marked PR #7109 as ready for review.

Wasmtime GitHub notifications bot (Sep 30 2023 at 00:24):

alexcrichton requested fitzgen for a review on PR #7109.

Wasmtime GitHub notifications bot (Sep 30 2023 at 00:24):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7109.

Wasmtime GitHub notifications bot (Sep 30 2023 at 00:24):

alexcrichton requested wasmtime-default-reviewers for a review on PR #7109.

Wasmtime GitHub notifications bot (Oct 02 2023 at 16:28):

fitzgen requested pchickey for a review on PR #7109.

Wasmtime GitHub notifications bot (Oct 03 2023 at 14:42):

alexcrichton updated PR #7109.

Wasmtime GitHub notifications bot (Oct 03 2023 at 14:42):

alexcrichton requested elliottt for a review on PR #7109.

Wasmtime GitHub notifications bot (Oct 03 2023 at 14:42):

alexcrichton requested sunfishcode for a review on PR #7109.

Wasmtime GitHub notifications bot (Oct 03 2023 at 20:18):

elliottt submitted PR review:

Looks great!

Wasmtime GitHub notifications bot (Oct 03 2023 at 20:18):

elliottt submitted PR review:

Looks great!

Wasmtime GitHub notifications bot (Oct 03 2023 at 20:18):

elliottt created PR review comment:

Should we add a preview2::spawn_blocking function that returns an AbortOnDropJoinHandle?

Wasmtime GitHub notifications bot (Oct 03 2023 at 20:50):

alexcrichton updated PR #7109.

Wasmtime GitHub notifications bot (Oct 03 2023 at 20:51):

alexcrichton has enabled auto merge for PR #7109.

Wasmtime GitHub notifications bot (Oct 03 2023 at 21:40):

alexcrichton updated PR #7109.

Wasmtime GitHub notifications bot (Oct 03 2023 at 21:41):

alexcrichton has enabled auto merge for PR #7109.

Wasmtime GitHub notifications bot (Oct 03 2023 at 22:49):

alexcrichton merged PR #7109.

Last updated: Dec 23 2024 at 12:05 UTC