Stream: git-wasmtime

Topic: wasmtime / PR #7099 feat(preview1): implement `poll_oneoff`

Wasmtime GitHub notifications bot (Sep 27 2023 at 20:52):

rvolosatovs opened PR #7099 from rvolosatovs:feat/preview2_poll_oneoff to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Implement preview1 poll_oneoff in the host adapter in terms of preview2 functionality.

Note, the difference in realtime clock timeout computation from https://github.com/bytecodealliance/wasmtime/blob/96f00830e7c16e283c06cd059a71ce832ed5f3e8/crates/wasi-preview1-component-adapter/src/lib.rs#L1695-L1722. It's largely the same, but handles more edge cases with less potential for errors.
I am happy to adapt the component adapter with the same logic if you agree with the change

Wasmtime GitHub notifications bot (Sep 27 2023 at 21:23):

rvolosatovs updated PR #7099.

Wasmtime GitHub notifications bot (Sep 27 2023 at 21:32):

rvolosatovs updated PR #7099.

Wasmtime GitHub notifications bot (Sep 27 2023 at 21:56):

rvolosatovs has marked PR #7099 as ready for review.

Wasmtime GitHub notifications bot (Sep 27 2023 at 21:56):

rvolosatovs requested pchickey for a review on PR #7099.

Wasmtime GitHub notifications bot (Sep 27 2023 at 21:56):

rvolosatovs requested wasmtime-core-reviewers for a review on PR #7099.

Wasmtime GitHub notifications bot (Oct 03 2023 at 10:21):

rvolosatovs updated PR #7099.

Wasmtime GitHub notifications bot (Oct 03 2023 at 10:21):

rvolosatovs updated PR #7099.

Wasmtime GitHub notifications bot (Oct 03 2023 at 11:44):

rvolosatovs updated PR #7099.

Wasmtime GitHub notifications bot (Oct 03 2023 at 12:10):

rvolosatovs has marked PR #7099 as ready for review.

Wasmtime GitHub notifications bot (Oct 03 2023 at 13:42):

alexcrichton submitted PR review:

Thanks again for this!

Wasmtime GitHub notifications bot (Oct 03 2023 at 15:07):

alexcrichton merged PR #7099.

Last updated: Dec 23 2024 at 13:07 UTC