Wasmtime GitHub notifications bot (Sep 26 2023 at 21:46): Wasmtime GitHub notifications bot (Sep 26 2023 at 21:46):alexcrichton opened PR #7094 from alexcrichton:update-wasm-tools to bytecodealliance:main:
Two major changes/reasons for this update:
Primarily pulling in support for semicolons-in-WIT files. Semicolons are not currently required, though, so I'll follow-up later with actual semicolons.
The syntax for parsing
(if ...)was fixed inwast. Previously it did not require(then ...)but this is required by the spec. New spec tests require this as well. This breaks existing text format tests which don't use(then ...)inside of an(if ...). Most tests were updated by hand butembenchen_*tests were updated by running through the old parser to produce non-s-expression using code.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Sep 26 2023 at 21:46):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #7094.
Wasmtime GitHub notifications bot (Sep 26 2023 at 21:46):alexcrichton requested fitzgen for a review on PR #7094.
Wasmtime GitHub notifications bot (Sep 26 2023 at 21:46):alexcrichton requested wasmtime-core-reviewers for a review on PR #7094.
Wasmtime GitHub notifications bot (Sep 26 2023 at 21:46):alexcrichton requested wasmtime-default-reviewers for a review on PR #7094.
Wasmtime GitHub notifications bot (Sep 26 2023 at 22:19):fitzgen submitted PR review:
:tada:
Wasmtime GitHub notifications bot (Sep 27 2023 at 00:20):alexcrichton closed without merge PR #7094.
Wasmtime GitHub notifications bot (Sep 27 2023 at 00:20):alexcrichton updated PR #7094.
Wasmtime GitHub notifications bot (Sep 27 2023 at 00:20):alexcrichton reopened PR #7094.
Wasmtime GitHub notifications bot (Sep 27 2023 at 15:54):alexcrichton merged PR #7094.
Last updated: Oct 23 2024 at 20:03 UTC