Stream: git-wasmtime

Topic: wasmtime / PR #7084 Optimize wasm calls ever-so-slightly

view this post on Zulip Wasmtime GitHub notifications bot (Sep 25 2023 at 17:46):

alexcrichton opened PR #7084 from alexcrichton:opt-wasm-calls to bytecodealliance:main:

This commit is a tiny optimization for host-to-wasm calls by inlining a few functions. One was a wasmtime-runtime function that's pretty simple and the other is the usage of the psm crate. Long ago psm was added to learn the current stack pointer and its routines are written in assembly, meaning that the calls can't be inlined. Nowadays with inline assembly it's possible to skip the external assembler entirely.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 25 2023 at 17:46):

alexcrichton requested fitzgen for a review on PR #7084.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 25 2023 at 17:46):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7084.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 25 2023 at 17:48):

alexcrichton updated PR #7084.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 25 2023 at 17:48):

alexcrichton updated PR #7084.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 25 2023 at 19:44):

fitzgen submitted PR review:

Nice! Do you happen to have microbenchmark deltas? No need to go out of your way to gather them if not.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 25 2023 at 20:59):

alexcrichton updated PR #7084.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 25 2023 at 20:59):

alexcrichton has enabled auto merge for PR #7084.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 25 2023 at 22:19):

alexcrichton merged PR #7084.

Last updated: Oct 23 2024 at 20:03 UTC