Stream: git-wasmtime

Topic: wasmtime / PR #7076 Remove manual impl of Error/Display

view this post on Zulip Wasmtime GitHub notifications bot (Sep 21 2023 at 23:51):

alexcrichton opened PR #7076 from alexcrichton:fix-error to bytecodealliance:main:

These conflict with auto-generated ones.

Closes https://github.com/bytecodealliance/wasmtime/issues/7074

view this post on Zulip Wasmtime GitHub notifications bot (Sep 21 2023 at 23:51):

alexcrichton requested pchickey for a review on PR #7076.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 21 2023 at 23:51):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7076.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 22 2023 at 04:35):

pchickey submitted PR review:

Thanks this was a real slap my own forehead moment.

I ended up tweak the tests to deal with my hack, so you'll have to tweak those back.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 22 2023 at 04:35):

pchickey submitted PR review:

Thanks this was a real slap my own forehead moment.

I ended up tweaking the tests to deal with my hack, so you'll have to tweak those back.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 22 2023 at 17:20):

alexcrichton updated PR #7076.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 22 2023 at 17:20):

alexcrichton has enabled auto merge for PR #7076.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 22 2023 at 18:28):

alexcrichton merged PR #7076.

Last updated: Nov 22 2024 at 16:03 UTC