Stream: git-wasmtime

Topic: wasmtime / PR #7069 Support resource maps in `component::...


view this post on Zulip Wasmtime GitHub notifications bot (Sep 20 2023 at 18:30):

alexcrichton opened PR #7069 from alexcrichton:configure-resource-types to bytecodealliance:main:

This commit adds support to component::bindgen! to specify resource types using the with key of the macro. This can be used to configure the T of Resource<T> to use a preexisting type rather than unconditionally generating a new empty enum to have a fresh type.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Sep 20 2023 at 18:30):

alexcrichton requested fitzgen for a review on PR #7069.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 20 2023 at 18:30):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7069.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 20 2023 at 18:30):

alexcrichton updated PR #7069.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 20 2023 at 21:01):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 20 2023 at 21:01):

pchickey created PR review comment:

it doesnt look like the foo/foo/a cases are covered here

view this post on Zulip Wasmtime GitHub notifications bot (Sep 20 2023 at 21:39):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 20 2023 at 21:39):

alexcrichton created PR review comment:

Oh I don't think that's actually possible via WIT right now since resources are either top-level imports, in an anonymous import, or in an interface which these three cases map to

view this post on Zulip Wasmtime GitHub notifications bot (Sep 20 2023 at 22:36):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 20 2023 at 22:36):

pchickey created PR review comment:

what exercises the a from line 46 and b from line 47?

view this post on Zulip Wasmtime GitHub notifications bot (Sep 21 2023 at 17:28):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 21 2023 at 17:28):

alexcrichton created PR review comment:

Ah that's foo/a and foo/b. The name of the world being "foo" is probably confusing here since the name of the world isn't used for these strings at all. The syntax here is definitely a bit made up by me and isn't exactly specified in WIT at all or anything like that.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 21 2023 at 17:48):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 21 2023 at 17:48):

pchickey created PR review comment:

got it! thank you.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 21 2023 at 23:05):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 21 2023 at 23:50):

pchickey merged PR #7069.


Last updated: Dec 23 2024 at 13:07 UTC