Stream: git-wasmtime

Topic: wasmtime / PR #7063 wasi: Fix a few issues around stdin


view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2023 at 20:14):

alexcrichton opened PR #7063 from alexcrichton:wasi-fix-stdin to bytecodealliance:main:

This commit is intended to address #6986 and some other issues related to stdin and reading it, notably:

These issues are addressed by refactoring the code in question. Note that this is similar to the logic of AsyncReadStream somewhat but that type is not appropriate in this context due to the singleton nature of stdin meaning that the per-stream helper task and per-stream buffer of AsyncReadStream are not appropriate.

Closees #6986

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2023 at 20:14):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7063.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2023 at 20:14):

alexcrichton requested fitzgen for a review on PR #7063.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2023 at 20:15):

alexcrichton requested pchickey for a review on PR #7063.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2023 at 20:28):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2023 at 20:28):

pchickey has enabled auto merge for PR #7063.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2023 at 22:24):

alexcrichton updated PR #7063.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2023 at 22:24):

alexcrichton has enabled auto merge for PR #7063.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2023 at 23:32):

alexcrichton merged PR #7063.


Last updated: Dec 23 2024 at 13:07 UTC