Stream: git-wasmtime

Topic: wasmtime / PR #7045 riscv64: Refactor how immediates are ...


view this post on Zulip Wasmtime GitHub notifications bot (Sep 14 2023 at 23:30):

alexcrichton requested elliottt for a review on PR #7045.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 14 2023 at 23:30):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #7045.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 14 2023 at 23:30):

alexcrichton opened PR #7045 from alexcrichton:refactor-riscv64-immediates to bytecodealliance:main:

I was curious to poke around the riscv64 backend and I wanted to touch up the handling of Imm{12,20} a bit after reading it. This commit is a refactoring of these two types with the following changes:

This commit ended up changing many runtests, but only their CLIF printing rather than their encoding. This change is due to the fact that Display now prints the logical value of the immediate rather than the raw bit representation as a base 10 integer. It's not intended that this commit actually changes any behavior, instead it should purely be internal refactorings.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Sep 14 2023 at 23:54):

alexcrichton updated PR #7045.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2023 at 09:12):

afonso360 submitted PR review:

LGTM! :+1: Thank you for looking into this. The Imm12 printing as unsigned has been slightly bothering me for a while now!

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2023 at 15:22):

alexcrichton has enabled auto merge for PR #7045.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2023 at 15:22):

alexcrichton updated PR #7045.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2023 at 16:43):

alexcrichton merged PR #7045.


Last updated: Dec 23 2024 at 12:05 UTC