Stream: git-wasmtime

Topic: wasmtime / PR #7044 Simplify bindings generation for prev...

Wasmtime GitHub notifications bot (Sep 14 2023 at 21:38):

alexcrichton opened PR #7044 from alexcrichton:cleanup-bindings to bytecodealliance:main:

This commit attempts to simplify the preview2::bindings module by consolidating everything into a single invocation of bindgen!. Previously this was separated out (I think) to handle some methods being async and not others, but the bindgen! macro has since grown the capability to have some functions async and not all.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 14 2023 at 21:38):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7044.

Wasmtime GitHub notifications bot (Sep 14 2023 at 21:38):

alexcrichton requested pchickey for a review on PR #7044.

Wasmtime GitHub notifications bot (Sep 14 2023 at 21:47):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Sep 14 2023 at 21:47):

pchickey has enabled auto merge for PR #7044.

Wasmtime GitHub notifications bot (Sep 14 2023 at 22:49):

pchickey merged PR #7044.

Last updated: Nov 22 2024 at 16:03 UTC