Stream: git-wasmtime

Topic: wasmtime / PR #7036 Gracefully handle failure to allocate...


view this post on Zulip Wasmtime GitHub notifications bot (Sep 14 2023 at 16:37):

rockwotj opened PR #7036 from rockwotj:main to bytecodealliance:main:

We run in a unique environment with very little memory, so
it's possible if there are many modules that we run out of memory,
callers should be able to handle this gracefully.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 14 2023 at 16:37):

rockwotj requested alexcrichton for a review on PR #7036.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 14 2023 at 16:37):

rockwotj requested wasmtime-core-reviewers for a review on PR #7036.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 14 2023 at 16:40):

alexcrichton submitted PR review:

Thanks! While you're here, could the expect be changed to context as well? That'll help attach the contextual error message of "unable to make memory executable" to the error returned using anyhow::Context.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 14 2023 at 16:42):

rockwotj updated PR #7036.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 14 2023 at 16:43):

alexcrichton has enabled auto merge for PR #7036.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 14 2023 at 17:57):

alexcrichton merged PR #7036.


Last updated: Oct 23 2024 at 20:03 UTC