Stream: git-wasmtime

Topic: wasmtime / PR #7035 winch: Add floating point rounding in...

Wasmtime GitHub notifications bot (Sep 14 2023 at 16:15):

elliottt opened PR #7035 from elliottt:trevor/winch-f32floor to bytecodealliance:main:

Add floating point rounding instructions using roundss and roundsd. The fall-back path is currently unimplemented, but once we have support for libcalls we can use the same fallback that the cranelift lowerings use.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 14 2023 at 16:16):

elliottt requested abrown for a review on PR #7035.

Wasmtime GitHub notifications bot (Sep 14 2023 at 16:16):

elliottt requested wasmtime-compiler-reviewers for a review on PR #7035.

Wasmtime GitHub notifications bot (Sep 14 2023 at 16:16):

elliottt requested fitzgen for a review on PR #7035.

Wasmtime GitHub notifications bot (Sep 14 2023 at 16:16):

elliottt requested wasmtime-core-reviewers for a review on PR #7035.

Wasmtime GitHub notifications bot (Sep 14 2023 at 16:16):

elliottt requested saulecabrera for a review on PR #7035.

Wasmtime GitHub notifications bot (Sep 14 2023 at 16:51):

saulecabrera submitted PR review:

LGTM, thanks!

Wasmtime GitHub notifications bot (Sep 14 2023 at 17:35):

saulecabrera merged PR #7035.

Last updated: Nov 22 2024 at 17:03 UTC